Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): master merge fixes for core-p2p worker #3359

Merged
merged 10 commits into from
Dec 20, 2019
Merged

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Dec 20, 2019

Summary

Some needed fixes to correct last master merge (for core-p2p worker).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #3359 into develop will increase coverage by 16.86%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3359       +/-   ##
============================================
+ Coverage    49.19%   66.05%   +16.86%     
============================================
  Files          438      438               
  Lines        12289    12283        -6     
  Branches      1662     1662               
============================================
+ Hits          6046     8114     +2068     
+ Misses        6221     4136     -2085     
- Partials        22       33       +11
Impacted Files Coverage Δ
packages/core-p2p/src/socket-server/worker.ts 20% <0%> (+0.95%) ⬆️
packages/core-p2p/src/network-monitor.ts 73.35% <0%> (+0.77%) ⬆️
packages/core-state/src/wallets/wallet-manager.ts 90.72% <0%> (+1.61%) ⬆️
packages/core-transaction-pool/src/memory.ts 98.66% <0%> (+2%) ⬆️
packages/core-transaction-pool/src/connection.ts 91.86% <0%> (+6.09%) ⬆️
packages/core-p2p/src/peer-connector.ts 67.44% <0%> (+6.97%) ⬆️
packages/core-p2p/src/utils/is-valid-version.ts 100% <0%> (+7.14%) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 62.96% <0%> (+7.4%) ⬆️
packages/core-p2p/src/peer-processor.ts 81.25% <0%> (+10.41%) ⬆️
...es/core-p2p/src/socket-server/versions/internal.ts 100% <0%> (+11.9%) ⬆️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e246093...d0e0ab4. Read the comment docs.

@spkjp spkjp merged commit bc71013 into develop Dec 20, 2019
@ghost ghost deleted the fix/p2p-worker branch December 20, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants