WIP feat(core-crypto): Rework crypto package to be instance-based #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity to instantiate from config or preset
…used with custom blocks
… different package
…erialisation step
|
This pull request introduces 1 alert when merging 5884991 into 8a2033a - view on LGTM.com new alerts:
|
…nd get static fee correctly
…lances on cryptoManager
|
This pull request introduces 1 alert when merging 242037e into 8a2033a - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 5fdc249 into 8a2033a - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 6450264 into 8a2033a - view on LGTM.com new alerts:
|
…ld be called with cryptoManager
|
This pull request introduces 1 alert when merging 5149778 into 8a2033a - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 81a3557 into 4b68d5f - view on LGTM.com new alerts:
|
|
Closing due to feedback that was given internally. |
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP Implementation of #3628
Refactors the
Cryptopackage to be instance based - this is now split into two packages:Cryptowhich contains default cryptography methods and managers, identities, transactions (and their de/serialisation methods) and libraries.Core-Cryptowhich wraps the otherCryptopackage, and which provides a more completeCryptoSuite, which also includes schema validation and blocks (including factory methods/managers, and de/serialisation methods).This allows more than one configuration to be loaded at run-time, avoids relying on global variables or the node module cache. This in turn reduces bugs caused by subtly shared state.
Checklist