chore: support fedora #3749
Merged
chore: support fedora #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
|
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
ghost
mentioned this pull request
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following on from #3738 I wanted to use Fedora rather than CentOS so I made the required changes to the installer script to make it compatible with both RHEL/CentOS and Fedora. It was a lot less work than anticipated, just adding
--skip-brokenso it only installsepel-releaseif it's available and won't abort the installation if it's not (since it's required for RHEL/CentOS, thus will be installed, but is not present in Fedora since it is not necessary for that distro).I confirmed that this makes Core installable and runnable on the latest Fedora and also continues to work fine on the latest CentOS.
If you only want to support RHEL/CentOS as far as RedHat distributions go then fair enough, feel free to close unmerged, but since I already wanted to fix it for myself so I could use my own server running Fedora I thought I'd share it with you in case you wanted to support Fedora out of the box as well as Debian/Ubuntu/RHEL/CentOS.
Checklist