Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-kernel): remove app.events and all of its usages #3835

Merged
merged 5 commits into from Jun 27, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jun 26, 2020

Summary

Along with #3833 fixes #3798. Requires #3833 to be merged first.

Checklist

  • Tests
  • Ready to be merged

@ghost ghost added Complexity: High labels Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #3835 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3835   +/-   ##
========================================
  Coverage    91.99%   91.99%           
========================================
  Files          620      620           
  Lines        14795    14796    +1     
  Branches      1849     1849           
========================================
+ Hits         13610    13611    +1     
  Misses         938      938           
  Partials       247      247           
Flag Coverage Δ
#functional 6.08% <0.00%> (-0.01%) ⬇️
#integration 9.59% <0.00%> (-0.01%) ⬇️
#unit 90.05% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
packages/core-manager/src/service-provider.ts 100.00% <ø> (ø)
packages/core-blockchain/src/blockchain.ts 97.60% <100.00%> (ø)
...hain/src/state-machine/actions/blockchain-ready.ts 100.00% <100.00%> (ø)
packages/core-database/src/database-service.ts 97.24% <100.00%> (ø)
packages/core-kernel/src/application.ts 100.00% <100.00%> (ø)
...tstrap/service-providers/boot-service-providers.ts 100.00% <100.00%> (ø)
...s/core-kernel/src/services/queue/drivers/memory.ts 97.50% <100.00%> (ø)
...ges/core-kernel/src/services/schedule/block-job.ts 100.00% <100.00%> (ø)
...ages/core-kernel/src/services/schedule/cron-job.ts 100.00% <100.00%> (ø)
packages/core-manager/src/listener.ts 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196c501...e3667d5. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review June 26, 2020 14:03
@faustbrian faustbrian merged commit 35ef592 into develop Jun 27, 2020
@ghost ghost deleted the refactor/remove-app-events branch June 27, 2020 02:02
@ghost ghost removed the Status: Needs Review label Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants