Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-kernel): remove app.log and all of its usages #3833

Merged
merged 6 commits into from Jun 26, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jun 26, 2020

Summary

Partially fixes #3798

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #3833 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3833   +/-   ##
========================================
  Coverage    91.87%   91.87%           
========================================
  Files          620      620           
  Lines        14787    14793    +6     
  Branches      1853     1853           
========================================
+ Hits         13585    13591    +6     
  Misses         938      938           
  Partials       264      264           
Flag Coverage Δ
#functional 6.09% <0.00%> (-0.01%) ⬇️
#integration 9.59% <6.81%> (+<0.01%) ⬆️
#unit 89.93% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
packages/core-state/src/state-builder.ts 100.00% <ø> (ø)
packages/core-api/src/server.ts 100.00% <100.00%> (ø)
packages/core-blockchain/src/blockchain.ts 97.60% <100.00%> (+0.01%) ⬆️
packages/core-database/src/service-provider.ts 92.50% <100.00%> (+0.19%) ⬆️
packages/core-kernel/src/application.ts 100.00% <100.00%> (ø)
...tstrap/service-providers/boot-service-providers.ts 100.00% <100.00%> (ø)
...ap/service-providers/register-service-providers.ts 94.64% <100.00%> (+0.19%) ⬆️
packages/core-p2p/src/peer-verifier.ts 99.42% <100.00%> (ø)
packages/core-p2p/src/socket-server/server.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/utils/check-dns.ts 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e943e56...a38afe9. Read the comment docs.

@faustbrian faustbrian merged commit bccf74d into develop Jun 26, 2020
@ghost ghost deleted the refactor/remove-app-log branch June 26, 2020 12:40
@ghost ghost removed the Status: Needs Review label Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants