Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-p2p): increase coverage to 100% #3884

Merged
merged 16 commits into from Jul 8, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR increases core-p2p package to 100%.

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #3884 into develop will decrease coverage by 84.33%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #3884       +/-   ##
===========================================
- Coverage    94.22%   9.88%   -84.34%     
===========================================
  Files          616     617        +1     
  Lines        14421   14411       -10     
  Branches      1733    1723       -10     
===========================================
- Hits         13588    1425    -12163     
- Misses         616   12880    +12264     
+ Partials       217     106      -111     
Flag Coverage Δ
#functional ?
#integration 9.88% <0.00%> (+<0.01%) ⬆️
#unit ?
Impacted Files Coverage Δ
packages/core-p2p/src/hapi-nes/client.ts 0.00% <ø> (-3.61%) ⬇️
packages/core-p2p/src/hapi-nes/plugin.ts 0.00% <0.00%> (ø)
packages/core-p2p/src/hapi-nes/socket.ts 0.00% <ø> (-4.10%) ⬇️
packages/core-p2p/src/network-state.ts 0.00% <ø> (-96.97%) ⬇️
packages/core-p2p/src/peer-communicator.ts 0.00% <ø> (-94.78%) ⬇️
packages/core-p2p/src/peer-processor.ts 0.00% <ø> (-91.12%) ⬇️
packages/core-p2p/src/peer-verifier.ts 6.85% <ø> (-92.58%) ⬇️
packages/core/src/cli.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/schemas.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 589 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0fe8b9...992dccb. Read the comment docs.

packages/core-p2p/src/hapi-nes/socket.ts Outdated Show resolved Hide resolved
@air1one air1one merged commit 1d91aeb into develop Jul 8, 2020
@ghost ghost deleted the test/core-p2p/increase-coverage branch July 8, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants