Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-p2p): split into 3 ports for blocks / transactions / others #3896

Merged
merged 7 commits into from
Jul 17, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jul 14, 2020

Summary

Split p2p into 3 different ports, so that we have specific port for blocks / transactions / others and therefore allowing to fine-tune rate limit and other networking settings outside the app (with iptables for example).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High labels Jul 14, 2020
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #3896 into develop will decrease coverage by 0.09%.
The diff coverage is 91.01%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3896      +/-   ##
===========================================
- Coverage    97.61%   97.51%   -0.10%     
===========================================
  Files          618      627       +9     
  Lines        14439    14516      +77     
  Branches      1726     1725       -1     
===========================================
+ Hits         14095    14156      +61     
- Misses         155      171      +16     
  Partials       189      189              
Flag Coverage Δ
#functional 6.76% <0.00%> (+<0.01%) ⬆️
#integration 9.84% <2.39%> (-0.04%) ⬇️
#unit 95.76% <91.01%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-p2p/src/schemas.ts 100.00% <ø> (ø)
packages/core-p2p/src/socket-server/routes/peer.ts 100.00% <ø> (ø)
...ackages/core-p2p/src/socket-server/schemas/peer.ts 100.00% <ø> (ø)
...ckages/core-p2p/src/socket-server/routes/blocks.ts 62.50% <62.50%> (ø)
.../core-p2p/src/socket-server/routes/transactions.ts 62.50% <62.50%> (ø)
packages/core-p2p/src/socket-server/server.ts 84.61% <77.77%> (-15.39%) ⬇️
packages/core-forger/src/client.ts 97.10% <95.23%> (-1.24%) ⬇️
packages/core-p2p/src/enums.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/listeners.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/network-monitor.ts 99.62% <100.00%> (+<0.01%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5222b5c...c59f850. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jul 14, 2020

This pull request introduces 1 alert when merging 48b3fcf into 5222b5c - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@air1one air1one marked this pull request as ready for review July 15, 2020 13:02
@faustbrian faustbrian merged commit 9796d13 into develop Jul 17, 2020
@ghost ghost deleted the feat/p2p-split-ports branch July 17, 2020 05:54
@ghost ghost removed the Status: Needs Review label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants