Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-database): expose two methods for findByHeightRangeWithTransactions #3906

Merged
merged 6 commits into from
Jul 23, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR creates two similar methods findByHeightRangeWithTransactions and findByHeightRangeWithTransactionsForDownload. It fixes the problem on node boot, because serialized transaction cannot be verified by block schema. Second method is used for p2p purposes.

Checklist

  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #3906 into develop will decrease coverage by 83.82%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3906       +/-   ##
============================================
- Coverage    97.52%   13.69%   -83.83%     
============================================
  Files          628      628               
  Lines        14526    14534        +8     
  Branches      1727     1728        +1     
============================================
- Hits         14166     1990    -12176     
- Misses         171    12429    +12258     
+ Partials       189      115       -74     
Flag Coverage Δ
#functional 6.77% <83.33%> (+0.01%) ⬆️
#integration 9.83% <0.00%> (-0.01%) ⬇️
#unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 0.00% <0.00%> (-97.23%) ⬇️
...core-database/src/repositories/block-repository.ts 89.04% <90.90%> (-7.89%) ⬇️
packages/core/src/cli.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/schemas.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/commands/top.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-cli/src/contracts.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-forger/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/listeners.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 561 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ce984...8efa3e8. Read the comment docs.

@air1one air1one merged commit dc431fa into develop Jul 23, 2020
@ghost ghost deleted the fix/core-daabase/transactions-for-download branch July 23, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants