Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-kernel): increase test coverage #4032

Merged
merged 5 commits into from
Sep 21, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Sep 15, 2020

Summary

Solves #4028

Increase core-kernel coverage to 100 %.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2020

This pull request fixes 2 alerts when merging a4fc10e into 956d629 - view on LGTM.com

fixed alerts:

  • 2 for Missing await

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #4032 into develop will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4032      +/-   ##
===========================================
+ Coverage    96.46%   96.72%   +0.25%     
===========================================
  Files          715      715              
  Lines        17235    17227       -8     
  Branches      2098     2089       -9     
===========================================
+ Hits         16626    16662      +36     
+ Misses         418      402      -16     
+ Partials       191      163      -28     
Flag Coverage Δ
#functional 5.97% <0.00%> (+<0.01%) ⬆️
#integration 10.19% <0.00%> (+<0.01%) ⬆️
#unit 94.70% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/core-kernel/src/services/config/watcher.ts 100.00% <ø> (+8.33%) ⬆️
...s/core-kernel/src/services/queue/drivers/memory.ts 100.00% <ø> (+2.50%) ⬆️
...l/src/services/search/standard-criteria-service.ts 100.00% <ø> (+9.18%) ⬆️
...core-kernel/src/services/validation/drivers/joi.ts 100.00% <ø> (+6.89%) ⬆️
packages/core-kernel/src/utils/ipc-handler.ts 100.00% <ø> (+18.18%) ⬆️
packages/core-kernel/src/utils/is-block-chained.ts 100.00% <ø> (+4.16%) ⬆️
packages/core-kernel/src/utils/search.ts 100.00% <ø> (+1.72%) ⬆️
...ap/service-providers/register-service-providers.ts 100.00% <100.00%> (+5.35%) ⬆️
...s/core-kernel/src/services/cache/drivers/memory.ts 100.00% <100.00%> (+5.71%) ⬆️
.../core-kernel/src/services/events/drivers/memory.ts 100.00% <100.00%> (+3.38%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773eb8c...222489c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2020

This pull request fixes 2 alerts when merging 222489c into 773eb8c - view on LGTM.com

fixed alerts:

  • 2 for Missing await

@air1one air1one merged commit ac01f55 into develop Sep 21, 2020
@ghost ghost deleted the test/core-kernel/increase-coverage branch September 21, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants