Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: 2.7 #4033

Merged
merged 51 commits into from
Sep 17, 2020
Merged

merge: 2.7 #4033

merged 51 commits into from
Sep 17, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Sep 15, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

air1one and others added 30 commits June 27, 2020 05:03
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #4033 into develop will decrease coverage by 0.82%.
The diff coverage is 96.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4033      +/-   ##
===========================================
- Coverage    98.79%   97.97%   -0.83%     
===========================================
  Files          638      638              
  Lines        14797    14855      +58     
  Branches      1739     1753      +14     
===========================================
- Hits         14619    14554      -65     
- Misses         104      222     +118     
- Partials        74       79       +5     
Flag Coverage Δ
#functional 6.93% <3.03%> (-0.03%) ⬇️
#integration 11.48% <0.75%> (-0.06%) ⬇️
#unit 95.88% <95.45%> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-api/src/routes/delegates.ts 100.00% <ø> (ø)
...ckages/core-magistrate-api/src/resources/entity.ts 100.00% <ø> (ø)
...ackages/core-magistrate-api/src/routes/entities.ts 100.00% <ø> (ø)
packages/core-p2p/src/enums.ts 100.00% <ø> (ø)
...-framework/src/matchers/functional/vote-balance.ts 100.00% <ø> (ø)
.../core-transactions/src/handlers/two/htlc-refund.ts 100.00% <ø> (ø)
packages/core-webhooks/src/database.ts 100.00% <ø> (ø)
packages/core-p2p/src/peer-verifier.ts 98.85% <77.77%> (-1.15%) ⬇️
.../core-magistrate-crypto/src/transactions/entity.ts 97.95% <80.00%> (-2.05%) ⬇️
...ore-magistrate-transactions/src/handlers/entity.ts 98.92% <98.68%> (-1.08%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4ef20...482b1f1. Read the comment docs.

@air1one air1one marked this pull request as ready for review September 17, 2020 10:41
@faustbrian faustbrian merged commit a027491 into develop Sep 17, 2020
@ghost ghost deleted the develop-merge-2.7 branch September 17, 2020 12:29
@ghost ghost removed the Status: Needs Review label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants