fix(core-webooks): ignore type errors thrown with lowdb deep methods #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an issue with lowdb where lodash errors are thrown on certain deep method calls: typicode/lowdb#233 This issue seems to occur to some nodes *randomly* when re-building core-webhooks. By adding a ts-ignore comment above the methods that cause the type error, core-webhooks can build without issue.
deanpress
requested review from
air1one,
faustbrian and
kristjank
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
air1one
approved these changes
Sep 10, 2020
|
A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
|
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
ghost
mentioned this pull request
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue with lowdb where lodash errors are thrown on certain deep method calls if another package or plugin has a
@types/lowdbdependency: typicode/lowdb#233By adding a ts-ignore comment above the methods that cause the type error, core-webhooks can build without issue.