Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: crypto endpoint #122

Merged
merged 1 commit into from
Sep 3, 2019
Merged

feat: crypto endpoint #122

merged 1 commit into from
Sep 3, 2019

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 2, 2019

Adds the node/configuration/crypto endpoint.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Sep 2, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Sep 2, 2019
@sleepdefic1t sleepdefic1t self-requested a review September 2, 2019 23:40
sleepdefic1t
sleepdefic1t approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@sleepdefic1t sleepdefic1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build failures unrelated to these changes.

  • macOS: submitter is building in standard CircleCI
  • appveyor: known build issues.

Looks good, thank you @dated

@ghost
Copy link

ghost commented Sep 2, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Sep 2, 2019
@ghost
Copy link

ghost commented Sep 3, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Sep 3, 2019
@faustbrian faustbrian merged commit cd1ac89 into ArkEcosystemArchive:develop Sep 3, 2019
@ghost
Copy link

ghost commented Sep 3, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the feat/crypto-endpoint branch September 3, 2019 04:51
@ghost ghost mentioned this pull request Sep 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

@sleepdefic1t sleepdefic1t sleepdefic1t approved these changes

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Medium Less than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dated @sleepdefic1t @faustbrian