refactor: let core auto-detect configuration #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Low
|
👌 I will merge to a new branch so it can be changed in this repo |
ghost
removed
the
Status: In Progress
ghost
mentioned this pull request
ItsANameToo
pushed a commit
that referenced
this pull request
May 27, 2019
* feat: implement cli, alias & env caching (#52) * refactor: let core auto-detect configuration * refactor: copy configuration on start if the bridgechain directory exists * refactor: better configuration publishment check * feat: check core config on start * fix: var curly braces in strings * fix: move core config on start to after dir check * fix: navigate to core path for config setup * fix: check if .config directories don't exist * fix: args json return when already processed * feat: store env data * fix: use .config path * feat: create alias for bridgechain * fix: don't abort when stopping and no network * fix: path export in profile for vagrant * chore: remove comment * refactor: make core alias global * feat: update core package & cli output * fix: pass network into stop commands * feat: improvements to deployer setup (#53) * feat: peer install option * fix: drop current user if exists * fix: drop owned objects by current user if exists * fix: drop all core databases if exists * fix: allow for no owned databases * fix: don't sudo yarn * fix: git properties in sample config * refactor: check for empty core origin * fix: if pull fails, try master * fix: skip drop local user on failure * fix: ignore network reach on first start * fix: prefix if number * chore: set explorer ip default to all ips * chore: editorconfig for js deployer script * fix: milestones generation for rewards per block * fix: dynamic fees toggle * fix: license & git checks for null/empty * fix: list user's databases * feat: modify core install script * feat: use chain name as alias for core * fix: alias setup to correct path * fix: avoid global variable name clash * feat: force public core ip for explorer if 127 * refactor: only load env if no json * chore: deploy core 2.3.22 * fix: remove core published config * fix: prevent non-alphanum chars in chain name * refactor: improve for peer script * fix: multiline install.sh bug * feat: allow setting vendorfield length * fix: install.sh process * fix: remove exec at end of install.sh * refactor: blocktime all lowercase * fix: add vendorFieldLength to joi schema * fix: vendorFieldLength case in json * fix: use correct name for network * fix: re-add chain name for deployer config * fix: hardcoded paths for install.sh * refactor: remove peer install option * chore: add vendorfield length to readme & configs (#62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deployer has created all configurations we copy them to
$HOME/.config/TOKEN-core/*and remove the usage ofCORE_PATH_CONFIGso that core can auto-detect the configurations which also resolves the issue of having to manually copy over thedelegates.jsonfile.