Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Dashboard transactions reloading and slowness #1011

Closed
zillionn opened this issue Jan 22, 2019 · 4 comments
Closed

Dashboard transactions reloading and slowness #1011

zillionn opened this issue Jan 22, 2019 · 4 comments
Labels
Type: Bug The issue relates to broken or incorrect behaviour.

Comments

@zillionn
Copy link
Contributor

Platform (please complete the following information):

  • macOS Mojave 10.14.2 (18C54)
  • Desktop Wallet 2.2.0

Describe the bug
Two issues:

  • everytime I got to the Dashboard, all the txs are gone and reloaded
  • new txs do not appear without reloading, even though I get a New transfer: ... message

How to reproduce the bug
Steps to reproduce the behaviour:

  1. Go to Dashboard and wait to load your last txs
  2. Go to Wallets page
  3. Go back to Dashboard and all txs will be gone
  4. After that send tx to some of your wallets from some other client and wait. You'll get a New transfer message but the tx will not appear on the dashboard
@j-a-m-l j-a-m-l added the Type: Bug The issue relates to broken or incorrect behaviour. label Feb 1, 2019
@j-a-m-l
Copy link
Contributor

j-a-m-l commented Feb 1, 2019

This could be fixed adding a global caching of transactions, as proposed on #894

A simpler alternative is caching only those transactions, and request and update on the background. From that we could extend this technique to other parts of the application, although it would be harder due having to deal with pagination, etc.

@zillionn
Copy link
Contributor Author

zillionn commented Mar 16, 2019

I have 13 wallets and 9 contacts and something else strange is happening. I'm watching the network requests and all the requests are finished but there is like 5-6 seconds delay until I see the txs on the dashboard. So for me it takes 10s to finish all requests and another 6s to show the txs and during that last 6s the app is unresponsive. I guess parsing the data is too slow/not optimized.

And I thought the new core is able to query all the wallets with one request, isn't it? Or that's coming with 2.3?

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Mar 18, 2019

The problem of the 2 comment was not the parsing per se, but storing that data. It was solve on #1124.

Reloading the transactions would be fixed when implementing the cache for transactions probably, although there are other ideas that could improve it before.

@j-a-m-l j-a-m-l closed this as completed Mar 18, 2019
@ghost
Copy link

ghost commented Mar 18, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

@j-a-m-l j-a-m-l changed the title Dashboard transactions Dashboard transactions reloading and slowness Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug The issue relates to broken or incorrect behaviour.
Projects
None yet
Development

No branches or pull requests

2 participants