This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
perf: save regular and Ledger wallets at once instead of dispatching multiple Vuex actions #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-a-m-l
requested review from
alexbarnsley,
faustbrian and
luciorubeens
as code owners
March 14, 2019 00:53
ghost
added
Complexity: Undetermined
Needs specialized, in-depth review.
Type: Performance
The issue or pull request relates to performance.
labels
Mar 14, 2019
j-a-m-l
changed the title
[WIP] perf: save regular and Ledger wallets at once instead of dispatching multiple Vuex actions
perf: save regular and Ledger wallets at once instead of dispatching multiple Vuex actions
Mar 14, 2019
ghost
mentioned this pull request
Mar 17, 2019
Codecov Report
@@ Coverage Diff @@
## develop #1124 +/- ##
==========================================
+ Coverage 40.96% 41.06% +0.1%
==========================================
Files 215 215
Lines 5454 5481 +27
Branches 1067 1064 -3
==========================================
+ Hits 2234 2251 +17
- Misses 3096 3106 +10
Partials 124 124
Continue to review full report at Codecov.
|
luciorubeens
approved these changes
Mar 18, 2019
ghost
deleted the
store-bulk-actions
branch
March 18, 2019 13:11
ghost
mentioned this pull request
Mar 24, 2019
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Undetermined
Needs specialized, in-depth review.
Type: Performance
The issue or pull request relates to performance.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR revamps the
wallet
action of the Synchronizer service to save the fetched data of each wallet in 1 Vuex commit on thewallet
store and 1 commit on theledger
store.This has reduced the processing time from ~3000-6500ms to 500-2500ms, and it makes the UI less laggy.
Types of changes
Checklist