Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

perf: save regular and Ledger wallets at once instead of dispatching multiple Vuex actions #1124

Merged
merged 11 commits into from
Mar 18, 2019

Conversation

j-a-m-l
Copy link
Contributor

@j-a-m-l j-a-m-l commented Mar 14, 2019

Proposed changes

This PR revamps the wallet action of the Synchronizer service to save the fetched data of each wallet in 1 Vuex commit on the wallet store and 1 commit on the ledger store.

This has reduced the processing time from ~3000-6500ms to 500-2500ms, and it makes the UI less laggy.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Performance The issue or pull request relates to performance. labels Mar 14, 2019
@j-a-m-l j-a-m-l changed the title [WIP] perf: save regular and Ledger wallets at once instead of dispatching multiple Vuex actions perf: save regular and Ledger wallets at once instead of dispatching multiple Vuex actions Mar 14, 2019
@codecov-io
Copy link

codecov-io commented Mar 18, 2019

Codecov Report

Merging #1124 into develop will increase coverage by 0.1%.
The diff coverage is 73.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #1124     +/-   ##
==========================================
+ Coverage    40.96%   41.06%   +0.1%     
==========================================
  Files          215      215             
  Lines         5454     5481     +27     
  Branches      1067     1064      -3     
==========================================
+ Hits          2234     2251     +17     
- Misses        3096     3106     +10     
  Partials       124      124
Impacted Files Coverage Δ
src/renderer/store/modules/wallet.js 45.78% <0%> (-6.28%) ⬇️
src/renderer/store/modules/ledger.js 74.75% <0%> (-1.11%) ⬇️
src/renderer/services/synchronizer/wallets.js 71.42% <87.32%> (+7.69%) ⬆️
src/renderer/components/Network/NetworkModal.vue 4.22% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ca9de...ffeeedd. Read the comment docs.

@luciorubeens luciorubeens merged commit 2a49f5b into develop Mar 18, 2019
@ghost ghost deleted the store-bulk-actions branch March 18, 2019 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Performance The issue or pull request relates to performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants