Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Latest transactions overview shows transactions of contacts too #1133

Closed
TwerkingGorilla opened this issue Mar 17, 2019 · 5 comments
Closed
Labels
Type: Bug The issue relates to broken or incorrect behaviour.

Comments

@TwerkingGorilla
Copy link

TwerkingGorilla commented Mar 17, 2019

Platform (please complete the following information):

  • OS: Windows 10
  • Version (e.g. Desktop Wallet 2.3.0)

Describe the bug
Wallet update states:
New behavior now displays the 50 latest transactions of all wallets combined on the dashboard.

Bug:
Overview of latest transactions now also shows transactions made/received by addresses stored as contacts, while it should only show transactions to- and from your addresses. In my 50 latest transactions list, there are 8 occurences of my contacts reveiving a transaction; it may be that it is the receiving transactions only and not the sending transactions that are displayed.

Screenshots
In the below screenshot, you see litebit and bittrex as contacts, the address that sent to litebit is also not one of my contacts.
afbeelding

@ghost
Copy link

ghost commented Mar 17, 2019

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l j-a-m-l added the Type: Bug The issue relates to broken or incorrect behaviour. label Mar 18, 2019
@j-a-m-l
Copy link
Contributor

j-a-m-l commented Mar 18, 2019

I can confirm that this is happening on latest version, but it's already fixed on #1124.

@j-a-m-l j-a-m-l closed this as completed Mar 18, 2019
@ghost
Copy link

ghost commented Mar 18, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

@zillionn
Copy link
Contributor

I thought it's intentional 🤣

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Mar 18, 2019

IIRC on the initial implementation, both wallets and contacts were displayed together, but since we changed that, it should have been changed too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug The issue relates to broken or incorrect behaviour.
Projects
None yet
Development

No branches or pull requests

3 participants