Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Side menu in horizontal mode has menu items aligned to the top #1632

Closed
brenopolanski opened this issue Jan 29, 2020 · 6 comments · Fixed by #1638
Closed

Side menu in horizontal mode has menu items aligned to the top #1632

brenopolanski opened this issue Jan 29, 2020 · 6 comments · Fixed by #1638
Labels
Difficulty: Beginner The issue doesn't require any specific knowledge about the code base. Type: Bug The issue relates to broken or incorrect behaviour.

Comments

@brenopolanski
Copy link
Contributor

Expected Behavior

Screenshot from 2020-01-28 21-38-57

Current Behavior

Screenshot from 2020-01-28 21-39-15

Possible Solution

(1) For the menu items Settings and Network Status set height: 100% or use tailwindcss h-full.

(2) The alignment of the app in horizontal mode is squeezed with the right scroll. Removing the width: calc(100vw + 1rem); in https://github.com/ArkEcosystem/desktop-wallet/blob/develop/src/renderer/App.vue#L435 it works well.

Steps to Reproduce (for bugs)

  1. Just resize the app to 750px

Peek 2020-01-28 22-01

Your Environment

  • Version used: ark-desktop-wallet 2.7.0
  • Environment name and version: Chrome v76.0.3809.146 - Node.js v12.4.0
  • Operating System and version: Ubuntu 19.10
@dated
Copy link
Contributor

dated commented Jan 29, 2020

FYI the adjusted width is necessary so when the Blur effect is applied the background color doesn't bleed into the blurred area. So it's probably a padding that is missing somewhere.

@dated
Copy link
Contributor

dated commented Jan 29, 2020

I misunderstood initially, the widths are just fine. The scroll bar however doesn't appear on all OS - MacOS for instances hides it by default and shows it only while scrolling.

@brenopolanski
Copy link
Contributor Author

I misunderstood initially, the widths are just fine. The scroll bar however doesn't appear on all OS - MacOS for instances hides it by default and shows it only while scrolling.

Hey @dated can you take a test? Look for https://github.com/ArkEcosystem/desktop-wallet/blob/develop/src/renderer/App.vue#L435 and remove or comment this line and tell me what happens - attach a screenshot here, if possible.

@dated
Copy link
Contributor

dated commented Jan 29, 2020

I had a look this morning and saw that the blur is buggy again at this moment and needs to be refactored probably, so that css selector might need some changes as well. I'll get back to it tonight and open a separate issue if suitable.

@brenopolanski brenopolanski added Difficulty: Beginner The issue doesn't require any specific knowledge about the code base. Type: Bug The issue relates to broken or incorrect behaviour. labels Jan 29, 2020
@dated
Copy link
Contributor

dated commented Jan 30, 2020

I will submit fixes for the icons and various other issues with the app menu together with a fix for #1636.

@dated
Copy link
Contributor

dated commented Jan 30, 2020

Regarding the scrollbar I simply adjusted the height of the component by subtracting the height of the top menu - this way there won't be a scrollbar to begin with.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Difficulty: Beginner The issue doesn't require any specific knowledge about the code base. Type: Bug The issue relates to broken or incorrect behaviour.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants