refactor: simplify blurred modal backdrop & ui tweaks #1638
Conversation
dated
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Medium
dated
changed the title
|
LGTM! I tested here and this PR solved the problems in the issue #1632 👍 |
ghost
mentioned this pull request
| @@ -154,9 +129,6 @@ export default { | |||
| }), | |||
|
|
|||
| computed: { | |||
| hasBlurFilter () { | |||
There was a problem hiding this comment.
I'm getting the message on my devtools console: Property or method "hasBlurFilter" is not defined on the instance but referenced during render. Because of hasBlurFilter here:
desktop-wallet/src/renderer/App.vue
Line 83 in 6eb4b85
There was a problem hiding this comment.
Looks like the button-dropdown portal got added in one of the merges, I'll need to take a look at how it uses the blur class.
There was a problem hiding this comment.
Ok, looks like the blur on the button dropdown can be safely removed. Strangely the button dropdown wasn't positioned correctly for me during development (this.$refs.buttonDropdown always being undefined) while it displays correctly on 2.8.0, therefore I added a resize handler to also reposition the dropdown while it is open. @alexbarnsley could you have a look at this also? In particular 85700dc which adds the resize handler.
|
Closes #1639 |
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
ghost
added
the
Status: Member Approved
alexbarnsley
added
the
Bounty: Tier 4
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
mentioned this pull request
Summary
Closes #1632, closes #1636.
Also includes several other tweaks to the menu and padding, and fixes the rounded borders on the wallet details.
There's are some more problems with the wallet details component but that will require some more investigation.
Checklist