Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Custom peer #1687

Closed
zillionn opened this issue Feb 20, 2020 · 2 comments · Fixed by #1692
Closed

Custom peer #1687

zillionn opened this issue Feb 20, 2020 · 2 comments · Fixed by #1692
Labels
Type: Bug The issue relates to broken or incorrect behaviour.

Comments

@zillionn
Copy link
Contributor

zillionn commented Feb 20, 2020 •
edited

  1. When click Connect custom peer it shows the port in the host field:

Screenshot 2020-02-20 at 14 45 52

  1. If I add a forward slash / after the host, i.e. http://1.2.3.4/, the peer will not be accepted:

Screenshot 2020-02-20 at 14 44 11

  • Version used: 2.8.0
  • Operating System and version: macOS Catalina 10.15.3
@ghost
Copy link

ghost commented Feb 20, 2020

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@dav1app dav1app linked a pull request Feb 20, 2020 that will close this issue
fix: peer validation #1621
Closed
3 tasks
@dav1app dav1app removed a link to a pull request Feb 21, 2020
fix: peer validation #1621
Closed
3 tasks
@dav1app dav1app mentioned this issue Feb 21, 2020
Merged
3 tasks
@dav1app dav1app linked a pull request Feb 21, 2020 that will close this issue
fix: custom peer host validation #1692
Merged
3 tasks
@brenopolanski brenopolanski added the Type: Bug The issue relates to broken or incorrect behaviour. label Feb 21, 2020
@ghost ghost mentioned this issue Feb 23, 2020
Closed
@ghost
Copy link

ghost commented Feb 26, 2020

This issue has been closed. If you wish to re-open it please provide additional information.

@ghost ghost mentioned this issue Mar 1, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Bug The issue relates to broken or incorrect behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: custom peer host validation ArkEcosystem/desktop-wallet
2 participants
@brenopolanski @zillionn