fix: peer validation

[dav1app]

Summary

• Fixes Request made to 'api/v2/node/configuration' using HTTP instead of HTTPS #1618 and other possible https -> http on fetching new peers.
• Accepts an instance of URL() on validatePeer.

Checklist

• Documentation (if necessary)
• Tests (if necessary)
• Ready to be merged

[codecov]

Codecov Report

Merging #1621 into develop will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1621   +/-   ##
========================================
  Coverage    63.91%   63.91%           
========================================
  Files          138      138           
  Lines         3813     3808    -5     
  Branches       797      795    -2     
========================================
- Hits          2437     2434    -3     
+ Misses        1150     1148    -2     
  Partials       226      226           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49aab6e...f2856e3. Read the comment docs.

[alexbarnsley]

This error resulted in the "Validating Peer" modal from not closing on its own. In fact, I can't close the connect modal until i enter a valid peer (or reload the wallet).

To use the devnet explorer as a peer I had to use http:// with port 443:

[alexbarnsley]

@brenopolanski could you give this a test for me please and let me know if you have any issues. Basically, test the steps in the issue which is referenced, and also try using different custom peers (e.g. https://dexplorer.ark.io). Thanks

[alexbarnsley]

@davimello28 could you fix the conflicts please

@brenopolanski don't forget to review this please

[brenopolanski]

@davimello28 @alexbarnsley

I did some tests using the steps in issue #1618. I realized that if you try to connect using a Connect custom peer with the following data:

It will show an error similar to this:

So close the modal, then try to connect again in ARK Devnet (on the Manage networks page). Now it will connect and this time using https:

[alexbarnsley]

@brenopolanski was you on a Devnet profile when you tried the test? "Wrong nethash" should only show when connecting to a peer on a different network? E.g. a devnet peer when on a mainnet profile

[brenopolanski]

@alexbarnsley when I did the tests I was in a mainet profile.

[alexbarnsley]

@brenopolanski that error is correct then, it shouldn't be able to connect to a https://dexplorer.ark.io peer when on the mainnet profile.

Was that the only thing you came across?

[brenopolanski]

@alexbarnsley

For now, yes. I'll investigate further and see if I look for other errors.

[alexbarnsley]

@brenopolanski great, thanks. Let me know if everything works okay so I can merge this

[brenopolanski]

The validate method is not linked to the connect button. I received the message on the browser console:

Property or method "emitConnect" is not defined on the instance but referenced during render...

Although I have updated the code, the modal does not close and does not show any alerts if the connection is successful or not.

[dav1app]

Consider #1692.