Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Balance in some currencies is shown as NaN #391

Closed
j-a-m-l opened this issue Nov 10, 2017 · 5 comments
Closed

Balance in some currencies is shown as NaN #391

j-a-m-l opened this issue Nov 10, 2017 · 5 comments
Assignees
@j-a-m-l

Comments

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Nov 10, 2017

nan balance in currency
@j-a-m-l j-a-m-l self-assigned this Nov 10, 2017
@luciorubeens
Copy link
Contributor

I think the currency value can be hidden in Devnet. The DARK token is DarkCoin, so it does not make sense to show.

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Nov 11, 2017

That could be an option, @luciorubeens, but if I connect to a new network that has its own token?

@j-a-m-l j-a-m-l removed the Type: Bug label Nov 13, 2017
@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Nov 13, 2017

I've removed the "Type: Bug" label because now it's more about deciding the behaviour in those cases.

Since connecting to other networks and tokens isn't common yet, we could hide that currency value except when connected to Mainnet.

@boldninja
Copy link
Member

boldninja commented Nov 13, 2017 •
edited
Loading

How about in network adding option for CMC ticker (everything except mainnet) if empty it hides the price pairs?

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Nov 13, 2017

Thanks @boldninja!

I like that option. I would explore it.

@alexbarnsley alexbarnsley mentioned this issue Nov 17, 2017
Merged
alexbarnsley pushed a commit that referenced this issue Dec 3, 2018
@j-a-m-l @faustbrian
refactor: improve the delegate registration modal (#391)
1321cad 
* feat: show the footer of the transaction modals when it exists
* misc: include the text of the footer of the delegate registration modal
* improvement: add the address of the delegate on the modal
* improvement: align the "Next" button to the left
* refactor: reword translation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@j-a-m-l j-a-m-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@j-a-m-l @luciorubeens @boldninja