Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Delegate Voting easier for "Outside 51" #803

Closed
michaelthecryptoguy opened this issue Dec 20, 2018 · 25 comments
Closed

Delegate Voting easier for "Outside 51" #803

michaelthecryptoguy opened this issue Dec 20, 2018 · 25 comments
Labels
Type: Feature The issue is a request for new functionality.

Comments

@michaelthecryptoguy
Copy link

Feature Request
An easier method to find/vote for someone outside the 51 delegates
Describe the solution you'd like
No Alternative or Solution at this time

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Dec 20, 2018

This could be improved allowing filtering on the table.

@kalgoop
Copy link
Contributor

kalgoop commented Dec 23, 2018

We can put up a input field in some modal where user can enter name of delegate he wants to vote (like it was in old version of desktop wallet)

@doubled1c3
Copy link

Recommending upgrading priority of this beyond "nice to have." A text box for autocompleting a delegate name for voting keeps playing field fair... if a new delegate appears and people want to vote for them but they have zero votes, the pagination is nearly endless to locate that delegate, placing an undue inconvenience on voting for a new delegate vs an incumbent forger... @j-a-m-l

@michaelthecryptoguy
Copy link
Author

I do agree, although I Know you guys are spending Alot of time breaking and shattering apart v1. Slowing glueing the pieces back together, all for one small piece not to fit right......

@faustbrian faustbrian added Type: Feature The issue is a request for new functionality. and removed Priority: Nice to have labels Jan 4, 2019
@j-a-m-l
Copy link
Contributor

j-a-m-l commented Jan 7, 2019

@doubled1c3 Yes, since the number of delegates is going to grow over time, this would become more necessary over time.

I'd suggest to accomplish it some kind of filtering on the whole table, instead of autocomplete (which would be a good feature too), because that characteristic allow users to search / locate delegates even when they are not interesting on voting them.

@zillionn
Copy link
Contributor

zillionn commented Jan 7, 2019

Maybe just make the username textfield and filter on key up:

screenshot 2019-01-07 at 18 10 04

@doubled1c3
Copy link

@zillionn Score. Maybe rename label to "Search delegates..."? I dunno

@michaelthecryptoguy
Copy link
Author

I don't think that would be a good idea, because that would "somewhat" imply that ark is associating itself with delegates

@alexbarnsley
Copy link
Member

I'm not sure I agree @michaelthecryptoguy, I don't think it gives any sort of impression. Even so, I don't think there's anything wrong with making it easier to vote since that's a key part of the network. The thing we don't want to associate with is the reward sharing delegates do to their voters, which is entirely optional to them and their proposals.

@boldninja
Copy link
Member

I like zillionn's approach will ask Oleg for input.

@dated
Copy link
Contributor

dated commented Jan 9, 2019

The vue-good-table component allows for easy column filtering, however you are limited to the currently displayed rows afaik. Which, we the current row count, is only helpful if you want to vote for an already forging delegate. Firing an API request to fetch the delegates on every key press should be avoided imho.

@dated
Copy link
Contributor

dated commented Jan 9, 2019

Kinda related: #763. A (toggable) input field outside of the table could easily be added. zillions approach as is would also remove the ability to sort by name.

@boldninja
Copy link
Member

boldninja commented Jan 9, 2019

now that I'm thinking more on this, searching for delegate could be performance intense on nodes when more delegates are registered. Maybe limit to like first 100 or 150 for search capabilities (by vote weight), but if you know the full username and you want to vote, you write it in the list it shows some kind of You wrote [searchFieldInput]. This delegate is currently outside the scope of search capabilities or doesn't exist. If you are sure it exists you can still vote for it by clicking here. Vote for [searchFieldInput].

Most people usually vote for those in the < 100 range anyways and it can be kind of unfriendly if your delegate is out of 51 and you need to scroll down and click on next page to load that and vote. I kind of liked input field in v1 where you could write full name if you knew it, upper solution could kind of be a mix of both worlds.

@zillionn
Copy link
Contributor

zillionn commented Jan 9, 2019

@dated So you can't load all delegates with the 1st request, cache them in the memory, and then just paginate them in the wallet? This way you can filter on keyup even 10,000 delegates. And ofcourse you'd add a little delay after keyup.

@alexbarnsley
Copy link
Member

Yes, delegates are already cached here: https://github.com/ArkEcosystem/desktop-wallet/blob/develop/src/renderer/store/modules/delegate.js#L60

But I think what dated means is we won't be able to add the filter to the column because the table system used would only filter the page that's visible

@zillionn
Copy link
Contributor

zillionn commented Jan 9, 2019

Hm, 2.1.1 is making an API request on every page change, like this:
http://5.196.105.33:4003/api/delegates?page=2&limit=51
http://5.196.105.33:4003/api/delegates?page=3&limit=51

And you could try filter like this. If more than 2 characters are entered in the search field, make rows per page = total delegates and then filter, if there is no other solution.

@doubled1c3
Copy link

@boldninja @alexbarnsley

We may be overthinking the need for a search, based on the hurdles present. I think a simple text box requiring them to type in the full name of the delegate exactly and a vote button would solve the issue at hand, searching delegates simply for the reason of locating them to vote for them, they already know who they want to vote for, we just need an easy way for them for vote for an exact delegate regardless of vote weight

@boldninja
Copy link
Member

I'll let Alex decide.

@zillionn
Copy link
Contributor

zillionn commented Jan 9, 2019

This is how you should do it imo. After you unvote, you should add the same banner like when you've voted for somebody:
screenshot 2019-01-09 at 23 01 21

But that banner should look something like this:
screenshot 2019-01-09 at 23 05 12
And when you click Vote for a delegate open a popup with 2 fields like the old v1 wallet.

@dated
Copy link
Contributor

dated commented Jan 9, 2019

Looks like there is the option for global search after all. I'll take a stab at it once i finish the other stuff and if noone does before then.

@michaelthecryptoguy
Copy link
Author

I like the simple text box and added banner idea.

@doubled1c3
Copy link

@dated @alexbarnsley has this issue been resolved for the upcoming release yet? Check this out: https://www.reddit.com/r/ArkEcosystem/comments/agn7t6/how_do_i_delegate_ark_through_a_transaction/

@dated
Copy link
Contributor

dated commented Jan 26, 2019

fyi i started on the implementation of this

image
image

@dated
Copy link
Contributor

dated commented Mar 8, 2019

Implemented / #1027

@j-a-m-l j-a-m-l closed this as completed Mar 8, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

No branches or pull requests

9 participants