Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: show voted delegates in wallet table #1099

Merged
merged 3 commits into from Feb 27, 2019
Merged

fix: show voted delegates in wallet table #1099

merged 3 commits into from Feb 27, 2019

Conversation

dated
Copy link
Contributor

@dated dated commented Feb 24, 2019

Proposed changes

Fixes #1098.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link

ghost commented Feb 24, 2019

@dated Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ghost
Copy link

ghost commented Feb 24, 2019

@alexbarnsley @j-a-m-l @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Feb 24, 2019
@dated
Copy link
Contributor Author

dated commented Feb 24, 2019 •
edited

showVotedDelegates can be removed theoretically, I haven't checked if the the other known forks are up to date and include the vote in their api response though.

@ghost ghost mentioned this pull request Feb 24, 2019
Closed
@ghost ghost added the Status: Needs Changes The pull request needs additional changes before it can be merged. label Feb 26, 2019
@ghost
Copy link

ghost commented Feb 26, 2019

@dated Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

@ghost
Copy link

ghost commented Feb 26, 2019

@luciorubeens The ci/circleci: test-node-11 job is failing as of ea92f1ef488568be2c3e52a684120e69982062cd. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@dated
Copy link
Contributor Author

dated commented Feb 27, 2019

There was some superfluous whitespace in your suggestion @luciorubeens, all good now.

@ghost
Copy link

ghost commented Feb 27, 2019

@dated A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Feb 27, 2019
@luciorubeens luciorubeens merged commit 59c1de3 into ArkEcosystem:develop Feb 27, 2019
@ghost
Copy link

ghost commented Feb 27, 2019

@dated Your pull request has been merged but was not assigned a bounty tier. @alexbarnsley @j-a-m-l @luciorubeens - please assign a bounty tier to this pull request in the next few days.

@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 27, 2019
@luciorubeens luciorubeens added Status: Needs Review The issue or pull request needs a review by a developer of the team. Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. labels Feb 27, 2019
@ghost
Copy link

ghost commented Feb 27, 2019

@dated Your pull request has been merged and marked as tier 4. It will earn you $10 USD.

@dated dated deleted the voted-delegates branch February 27, 2019 13:18
@ghost ghost mentioned this pull request Mar 3, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luciorubeens luciorubeens luciorubeens approved these changes

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley

@faustbrian faustbrian Awaiting requested review from faustbrian

@j-a-m-l j-a-m-l Awaiting requested review from j-a-m-l

Assignees
No one assigned
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member. Status: Needs Changes The pull request needs additional changes before it can be merged. Status: Needs Review The issue or pull request needs a review by a developer of the team. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vote info on Wallets page
2 participants
@dated @luciorubeens