Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show voted delegates in wallet table #1099

Merged
merged 3 commits into from Feb 27, 2019

Conversation

@dated
Copy link
Contributor

commented Feb 24, 2019

Proposed changes

Fixes #1098.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 24, 2019

@dated Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 24, 2019

@alexbarnsley @j-a-m-l @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2019

showVotedDelegates can be removed theoretically, I haven't checked if the the other known forks are up to date and include the vote in their api response though.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

@dated Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

@luciorubeens The ci/circleci: test-node-11 job is failing as of ea92f1ef488568be2c3e52a684120e69982062cd. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@dated dated force-pushed the dated:voted-delegates branch from ea92f1e to e300aeb Feb 26, 2019

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

There was some superfluous whitespace in your suggestion @luciorubeens, all good now.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@dated A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@luciorubeens luciorubeens merged commit 59c1de3 into ArkEcosystem:develop Feb 27, 2019

1 check passed

ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@dated Your pull request has been merged but was not assigned a bounty tier. @alexbarnsley @j-a-m-l @luciorubeens - please assign a bounty tier to this pull request in the next few days.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@dated Your pull request has been merged and marked as tier 4. It will earn you $10 USD.

@dated dated deleted the dated:voted-delegates branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.