fix: handle invalid address from qr code

[dated]

Summary

The InputDelegate component assumed that every address scanned from a qr code actually belonged to a delegate. This PR adds an additional check to make sure it does and removes the call to truncate the delegates username, since usernames are capped at a length of 20 by default.

Checklist

• Documentation (if necessary)
• Tests (if necessary)
• Ready to be merged

[ghost]

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[brenopolanski]

LGTM!

This PR solves the following problem, for instance:

If the wallet is using the mainnet and scanning a QR Code from a devnet delegate, the UI returns:

Using the code:

this.model = this.$store.getters['delegate/byAddress'](address).username

It will return undefined.

[brenopolanski]

@dated

There is an error with classList.includes (https://github.com/ArkEcosystem/desktop-wallet/blob/develop/src/renderer/components/Input/InputDelegate.vue#L246) and you can solve here on this PR.

The Element.classList is a read-only property that returns a live DOMTokenList collection of the class attributes of the element.

Source: https://developer.mozilla.org/en-US/docs/Web/API/Element/classList

So the methods available in the classList are:

• DOMTokenList.item(index)
• DOMTokenList.contains(token)
• DOMTokenList.add(token1[, token2[, ...tokenN]])
• DOMTokenList.remove(token1[, token2[, ...tokenN]])
• DOMTokenList.replace(oldToken, newToken)
• DOMTokenList.supports(token)
• DOMTokenList.toggle(token [, force])
• DOMTokenList.entries()
• DOMTokenList.forEach(callback [, thisArg])
• DOMTokenList.keys()
• DOMTokenList.values()

includes is not available in classList, so you can change to contains.

[dated]

I'll take a look!

[dated]

InputAddress, InputDelegate and InputSelect all have references to classList. I adjusted all three of them. The onBlur method could possibly be moved to it's own mixin, at least in InputAddress and InputDelegate it is exactly the same.

[brenopolanski]

InputAddress, InputDelegate and InputSelect all have references to classList. I adjusted all three of them. The onBlur method could possibly be moved to it's own mixin, at least in InputAddress and InputDelegate it is exactly the same.

Works fine @dated 👍

[brenopolanski]

@dated I agree with you about create a mixin for the onBlur method. Let's see what @alexbarnsley thinks about it...

[ghost]

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

[ghost]

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.