Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: off by one error in recipients validation and count in list title #1662

Merged
merged 8 commits into from
Feb 18, 2020
Merged

fix: off by one error in recipients validation and count in list title #1662

merged 8 commits into from
Feb 18, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Feb 11, 2020

Summary

  • fixes an off by one error causing the form validation to fail when the recipients count is equal to the maximum allowed recipients
  • allows to show the count / maximum allowed items in the InputEditableList component, see screenshots below

image

image

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Feb 11, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Feb 11, 2020
@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Feb 18, 2020
@ghost
Copy link

ghost commented Feb 18, 2020

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@alexbarnsley alexbarnsley merged commit 2dbcd91 into ArkEcosystem:develop Feb 18, 2020
@ghost
Copy link

ghost commented Feb 18, 2020

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@dated dated deleted the fix/max-recipients branch February 18, 2020 20:48
@alexbarnsley alexbarnsley added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Feb 18, 2020
@ghost
Copy link

ghost commented Feb 18, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants