Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: hide vote button for resigned delegates and add status #1682

Merged
merged 7 commits into from
Feb 19, 2020
Merged

fix: hide vote button for resigned delegates and add status #1682

merged 7 commits into from
Feb 19, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Feb 19, 2020

Summary

This PR hides the vote button for resigned delegates and adds an additional row showing the status of the delegate.

image

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Feb 19, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Feb 19, 2020
Copy link
Member

@alexbarnsley alexbarnsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you also remove the isResigned check on InputDelegate search please, since this modal change now highlights to the user that they're resigned

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Feb 19, 2020
@ghost
Copy link

ghost commented Feb 19, 2020

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@alexbarnsley alexbarnsley merged commit 154ac54 into ArkEcosystem:develop Feb 19, 2020
@ghost
Copy link

ghost commented Feb 19, 2020

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@alexbarnsley alexbarnsley added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Feb 19, 2020
@ghost
Copy link

ghost commented Feb 19, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the fix/resigned-delegate-vote branch February 19, 2020 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants