This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: notifications for magistrate transactions #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dated
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Low
alexbarnsley
approved these changes
Feb 28, 2020
ghost
added
the
Status: Member Approved
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
alexbarnsley
added
the
Bounty: Tier 4
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issues with the notifications for some magistrate transactions.
One problem with displaying the bridgechain name in the bridgechain transaction notifications is that the name is only available in the registration transaction. Update and resignation only hold the
bridgechainId, i.e. the genesis hash. For consistency the bridgechain id is displayed across all three bridgechain transaction types. The name of the bridgechain would have to be fetched through the api which shouldn't be of the synchronizers concern, or stored locally on the wallet. Happy to discuss options if you want the name displayed @alexbarnsley.The name of the business has been removed from the business update notifications, as there is no guarantee that the update includes a new name.
Checklist