Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bridgechain form ux when going to page 2 #1788

Merged
merged 12 commits into from Mar 17, 2020
Merged

Conversation

@alexbarnsley
Copy link
Member

alexbarnsley commented Mar 6, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1788 into develop will decrease coverage by 0.05%.
The diff coverage is 46.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1788      +/-   ##
===========================================
- Coverage    60.10%   60.05%   -0.06%     
===========================================
  Files          369      369              
  Lines         9187     9213      +26     
  Branches      1878     1887       +9     
===========================================
+ Hits          5522     5533      +11     
- Misses        3480     3492      +12     
- Partials       185      188       +3     
Impacted Files Coverage Δ
src/renderer/components/Input/InputPassword.vue 43.85% <0.00%> (-0.79%) ⬇️
...renderer/components/Passphrase/PassphraseInput.vue 63.63% <0.00%> (-1.18%) ⬇️
...ansactionForm/TransactionFormBridgechain/mixin.vue 81.16% <53.84%> (-2.75%) ⬇️
src/renderer/services/transaction.js 90.12% <0.00%> (-3.47%) ⬇️
...llet/WalletBusiness/WalletBusinessBridgechains.vue 98.27% <0.00%> (-1.73%) ⬇️
...nderer/components/Transaction/TransactionModal.vue 29.00% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e965c09...9892070. Read the comment docs.

faustbrian and others added 4 commits Mar 9, 2020
@alexbarnsley alexbarnsley dismissed stale reviews from brenopolanski and davimello28 via 1340082 Mar 16, 2020
@faustbrian faustbrian merged commit 5d2990a into develop Mar 17, 2020
5 of 7 checks passed
5 of 7 checks passed
eslint
Details
lint-unit (12.x)
Details
build-linux (12.x)
Details
build-macOS (12.x)
Details
build-windows (12.x)
Details
codecov/patch 46.66% of diff hit (target 60.10%)
Details
codecov/project 60.05% (+-0.06%) compared to e965c09
Details
@ArkEcosystemBot ArkEcosystemBot deleted the fix/bridgechain-ux branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.