Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: bridgechain form ux when going to page 2 #1788

Merged
merged 12 commits into from Mar 17, 2020
Merged

Conversation

alexbarnsley
Copy link
Member

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1788 into develop will decrease coverage by 0.05%.
The diff coverage is 46.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1788      +/-   ##
===========================================
- Coverage    60.10%   60.05%   -0.06%     
===========================================
  Files          369      369              
  Lines         9187     9213      +26     
  Branches      1878     1887       +9     
===========================================
+ Hits          5522     5533      +11     
- Misses        3480     3492      +12     
- Partials       185      188       +3     
Impacted Files Coverage Δ
src/renderer/components/Input/InputPassword.vue 43.85% <0.00%> (-0.79%) ⬇️
...renderer/components/Passphrase/PassphraseInput.vue 63.63% <0.00%> (-1.18%) ⬇️
...ansactionForm/TransactionFormBridgechain/mixin.vue 81.16% <53.84%> (-2.75%) ⬇️
src/renderer/services/transaction.js 90.12% <0.00%> (-3.47%) ⬇️
...llet/WalletBusiness/WalletBusinessBridgechains.vue 98.27% <0.00%> (-1.73%) ⬇️
...nderer/components/Transaction/TransactionModal.vue 29.00% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e965c09...9892070. Read the comment docs.

dav1app
dav1app previously approved these changes Mar 10, 2020
brenopolanski
brenopolanski previously approved these changes Mar 13, 2020
@brenopolanski brenopolanski added the Status: Member Approved The pull request has been approved by a member. label Mar 13, 2020
@alexbarnsley alexbarnsley dismissed stale reviews from brenopolanski and dav1app via 1340082 March 16, 2020 09:34
@faustbrian faustbrian merged commit 5d2990a into develop Mar 17, 2020
@ghost ghost deleted the fix/bridgechain-ux branch March 17, 2020 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants