Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add SvgIcon component #2012

Merged
merged 11 commits into from Jun 2, 2020
Merged

feat: add SvgIcon component #2012

merged 11 commits into from Jun 2, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Jun 1, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. labels Jun 1, 2020
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #2012 into 3.0-slate will decrease coverage by 8.85%.
The diff coverage is 70.58%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-slate    #2012      +/-   ##
=============================================
- Coverage      90.67%   81.81%   -8.86%     
=============================================
  Files             16       19       +3     
  Lines            118      143      +25     
  Branches           2        4       +2     
=============================================
+ Hits             107      117      +10     
- Misses            11       26      +15     
Impacted Files Coverage Δ
src/renderer/app/components/Navbar/Navbar.vue 100.00% <ø> (ø)
src/renderer/support/mixins/assets.ts 0.00% <0.00%> (ø)
src/renderer/support/services/image-manager.ts 0.00% <0.00%> (ø)
src/renderer/app/components/Button/Button.vue 100.00% <100.00%> (ø)
src/renderer/app/components/SvgIcon/SvgIcon.vue 100.00% <100.00%> (ø)
src/renderer/app/components/Toggle/Toggle.vue 100.00% <100.00%> (ø)
src/renderer/domain/profile/pages/ProfileNew.vue 91.30% <100.00%> (+0.39%) ⬆️
...c/renderer/domain/profile/pages/ProfileWelcome.vue 88.88% <100.00%> (+1.38%) ⬆️
...er/domain/wallet/components/WalletMnemonicList.vue 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7946bc4...14eb914. Read the comment docs.

@brenopolanski brenopolanski changed the title [WIP] feat: add SvgIcon component feat: add SvgIcon component Jun 1, 2020
@faustbrian faustbrian changed the title feat: add SvgIcon component feat: add SvgIcon component Jun 2, 2020
@faustbrian faustbrian merged commit 67ab6ed into 3.0-slate Jun 2, 2020
@ghost ghost deleted the feat/svg-icon-component branch June 2, 2020 01:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants