Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

test: enforce 100% coverage at all times #2015

Merged
merged 13 commits into from Jun 2, 2020
Merged

test: enforce 100% coverage at all times #2015

merged 13 commits into from Jun 2, 2020

Conversation

faustbrian
Copy link
Contributor

No description provided.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #2015 into 3.0-slate will increase coverage by 16.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           3.0-slate     #2015       +/-   ##
===============================================
+ Coverage      83.33%   100.00%   +16.66%     
===============================================
  Files             14        19        +5     
  Lines            108       136       +28     
  Branches           3         5        +2     
===============================================
+ Hits              90       136       +46     
+ Misses            18         0       -18     
Impacted Files Coverage Δ
src/renderer/app/components/Navbar/Navbar.vue 100.00% <ø> (ø)
src/renderer/support/services/http.ts 100.00% <ø> (+30.76%) ⬆️
src/renderer/app/components/Button/Button.vue 100.00% <100.00%> (ø)
...rer/app/components/ListDivided/ListDividedItem.vue 100.00% <100.00%> (ø)
src/renderer/app/components/SvgIcon/SvgIcon.vue 100.00% <100.00%> (ø)
src/renderer/app/components/Toggle/Toggle.vue 100.00% <100.00%> (ø)
src/renderer/domain/profile/pages/ProfileNew.vue 100.00% <100.00%> (+9.52%) ⬆️
...c/renderer/domain/profile/pages/ProfileWelcome.vue 100.00% <100.00%> (+14.28%) ⬆️
...er/domain/wallet/components/WalletMnemonicList.vue 100.00% <100.00%> (ø)
src/renderer/support/mixins/assets.ts 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18527bf...37c6596. Read the comment docs.

@faustbrian faustbrian changed the title refactor: clean up ImageManager and add tests for it test: enforce 100% coverage at all times Jun 2, 2020
@faustbrian faustbrian merged commit 9bcac19 into 3.0-slate Jun 2, 2020
@ghost ghost deleted the cleanup branch June 2, 2020 04:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant