This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
refactor: avoid default exports #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2020 05:55
ghost
added
Complexity: Medium
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2047 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 24 25 +1
Lines 142 143 +1
Branches 18 18
===========================================
+ Hits 142 143 +1
Continue to review full report at Codecov.
|
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously mentioned it should be avoided to use default exports because they lead to inconsistent naming and imports because you can use any name you want instead of being forced to use a specific one.