Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add form components #2053

Merged
merged 3 commits into from
Jun 8, 2020
Merged

feat: add form components #2053

merged 3 commits into from
Jun 8, 2020

Conversation

luciorubeens
Copy link
Contributor

Summary

Decouple form components from the Input component.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Jun 8, 2020
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #2053 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.0-react     #2053   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files             27        28    +1     
  Lines            159       182   +23     
  Branches          23        28    +5     
===========================================
+ Hits             159       182   +23     
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Form/Form.tsx 100.00% <100.00%> (ø)
src/app/components/Form/FormField.tsx 100.00% <100.00%> (ø)
src/app/components/Form/FormHelperText.tsx 100.00% <100.00%> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <100.00%> (ø)
src/app/components/Form/useFormField.tsx 100.00% <100.00%> (ø)
src/app/components/Input/Input.tsx 100.00% <100.00%> (ø)
src/app/components/SideBar/SideBar.tsx 100.00% <100.00%> (ø)
...app/components/SideBar/SideBarItem/SideBarItem.tsx 100.00% <100.00%> (ø)
...ains/profile/pages/CreateProfile/CreateProfile.tsx 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b79896...9c1cb48. Read the comment docs.

Copy link
Contributor

@clucasalcantara clucasalcantara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Really nice job man 😎

Since this is a shared feature for a lot of pages (settings, create profile etc) I think this is a good start to add e2e journey :3 maybe in a separated PR just covering that 💌

images (2)

@faustbrian
Copy link
Contributor

@luciorubeens conflicts

@luciorubeens
Copy link
Contributor Author

@faustbrian done

@faustbrian faustbrian merged commit 1bace1b into 3.0-react Jun 8, 2020
@ghost ghost deleted the feat/form-decouple branch June 8, 2020 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants