Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: contact us modal component #2080

Merged
merged 13 commits into from
Jun 10, 2020
Merged

feat: contact us modal component #2080

merged 13 commits into from
Jun 10, 2020

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Jun 9, 2020

Summary

  • Also Removes overflow for modal - not needed right now since the min-height was removed too

Tests will fail as it's waiting on changes in #2074

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #2080 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.0-react     #2080   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files             45        46    +1     
  Lines            298       303    +5     
  Branches          49        49           
===========================================
+ Hits             298       303    +5     
Impacted Files Coverage Δ
src/app/components/Modal/Modal.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
...rc/domains/help/components/ContactUs/ContactUs.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6572ce...a1ee228. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review June 10, 2020 01:56
@faustbrian faustbrian self-requested a review as a code owner June 10, 2020 01:56
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jun 10, 2020
@faustbrian faustbrian merged commit 7c536fc into 3.0-react Jun 10, 2020
@ghost ghost deleted the feat/contact-modal branch June 10, 2020 02:00
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants