Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: replace react-intl with react-i18next #2087

Merged
merged 10 commits into from
Jun 11, 2020
Merged

Conversation

clucasalcantara
Copy link
Contributor

@clucasalcantara clucasalcantara commented Jun 10, 2020

Summary

Update i18n logic and structure, also replaces react-intl for i18n next

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Jun 10, 2020
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #2087 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.0-react     #2087   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files             45        56   +11     
  Lines            298       378   +80     
  Branches          49        65   +16     
===========================================
+ Hits             298       378   +80     
Impacted Files Coverage Δ
src/app/components/Alert/Alert.tsx 100.00% <ø> (ø)
src/app/components/Dropdown/Dropdown.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
src/app/components/Select/Select.tsx 100.00% <ø> (ø)
...app/components/SideBar/SideBarItem/SideBarItem.tsx 100.00% <ø> (ø)
...ings/pages/Settings/available-settings/General.tsx 100.00% <ø> (ø)
...ins/wallets/components/SignMessage/SignMessage.tsx 100.00% <ø> (ø)
...omains/wallets/pages/ImportWallet/ImportWallet.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1c8fd...7a7f21b. Read the comment docs.

src/index.tsx Outdated Show resolved Hide resolved
src/app/i18n/index.ts Outdated Show resolved Hide resolved
.storybook/preview.js Outdated Show resolved Hide resolved
@alexbarnsley alexbarnsley mentioned this pull request Jun 10, 2020
3 tasks
@clucasalcantara clucasalcantara changed the title fix: i18n keys fix: i18n structure Jun 10, 2020
Copy link
Member

@alexbarnsley alexbarnsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tweaks but no show stoppers that I can see

src/domains/help/components/ContactUs/ContactUs.tsx Outdated Show resolved Hide resolved
@alexbarnsley
Copy link
Member

@faustbrian I think this is ready, I don't want to force merge without your approval since you likely changed codeowners for a reason

@faustbrian faustbrian changed the title fix: i18n structure refactor: replace react-intl with react-i18next Jun 11, 2020
@faustbrian faustbrian merged commit 4a4f459 into 3.0-react Jun 11, 2020
@ghost ghost deleted the fix/i18n-keys branch June 11, 2020 01:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants