Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: improve CreateWallet design #2121

Merged
merged 7 commits into from
Jun 12, 2020
Merged

refactor: improve CreateWallet design #2121

merged 7 commits into from
Jun 12, 2020

Conversation

luciorubeens
Copy link
Contributor

Summary

  • Fix Alert padding and icons
  • Fix MnemonicVerification checkmark icon
  • Fix Circle background when checked
  • Minor tweaks.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jun 12, 2020
@boldninja
chore: optimize 6 SVG(s)
c1f4901 
Optimized SVG(s):
- src/app/assets/svg/alert-danger.svg
- src/app/assets/svg/alert-default.svg
- src/app/assets/svg/alert-success.svg
- src/app/assets/svg/checkmark.svg
- src/app/assets/svg/download.svg
- src/app/assets/svg/ok.svg
@codecov
Copy link

codecov bot commented Jun 12, 2020 •
edited
Loading

Codecov Report

Merging #2121 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2121    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             45        77    +32     
  Lines            298       615   +317     
  Branches          49        96    +47     
============================================
+ Hits             298       615   +317
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
src/app/components/Select/Select.tsx 100.00% <ø> (ø)
...app/components/SideBar/SideBarItem/SideBarItem.tsx 100.00% <ø> (ø)
src/app/components/StepIndicator/StepIndicator.tsx 100.00% <ø> (ø)
src/domains/settings/pages/Settings/Settings.tsx 100.00% <ø> (ø)
...ings/pages/Settings/available-settings/General.tsx 100.00% <ø> (ø)
...s/wallets/components/MnemonicList/MnemonicList.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e887b...0647605. Read the comment docs.

@faustbrian
Copy link
Contributor

@luciorubeens conflicts

@faustbrian faustbrian merged commit 631155f into 3.0-react Jun 12, 2020
@ghost ghost deleted the fix/create-wallet-tweaks branch June 12, 2020 15:10
@ghost ghost mentioned this pull request Jun 14, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian faustbrian approved these changes

Assignees
No one assigned
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luciorubeens @faustbrian @boldninja