Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: move wallet components to domain #2131

Merged
merged 5 commits into from
Jun 15, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jun 14, 2020

Summary

Move FilterWallets and WalletsControl to dashboard domain

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner June 14, 2020 19:23
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jun 14, 2020
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #2131 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2131    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             45        87    +42     
  Lines            298       675   +377     
  Branches          49       105    +56     
============================================
+ Hits             298       675   +377     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Circle/Circle.tsx 100.00% <ø> (ø)
src/app/components/Divider/Divider.styles.ts 100.00% <ø> (ø)
src/app/components/Divider/Divider.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
src/app/components/Select/Select.tsx 100.00% <ø> (ø)
...app/components/SideBar/SideBarItem/SideBarItem.tsx 100.00% <ø> (ø)
src/app/components/StepIndicator/StepIndicator.tsx 100.00% <ø> (ø)
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bd0f3...e154b24. Read the comment docs.

Copy link
Contributor

@faustbrian faustbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files that were named .test.tsx should be renamed back to .test.tsx instead of .spec.tsx because it was intentionally in #2129

@faustbrian faustbrian merged commit 0b24cbf into 3.0-react Jun 15, 2020
@ghost ghost deleted the feat/move-wallet-components-to-domain branch June 15, 2020 01:41
@goga-m
Copy link
Contributor Author

goga-m commented Jun 15, 2020

My bad. I'll modify the following PRs accordingly.
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants