This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
refactor: move wallet components to domain #2131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Low
Less than 64 lines changed.
Type: Refactor
The pull request improves or enhances an existing implementation.
labels
Jun 14, 2020
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2131 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 45 87 +42
Lines 298 675 +377
Branches 49 105 +56
============================================
+ Hits 298 675 +377
Continue to review full report at Codecov.
|
3 tasks
ghost
mentioned this pull request
Jun 14, 2020
faustbrian
suggested changes
Jun 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files that were named .test.tsx
should be renamed back to .test.tsx
instead of .spec.tsx
because it was intentionally in #2129
ghost
deleted the
feat/move-wallet-components-to-domain
branch
June 15, 2020 01:41
My bad. I'll modify the following PRs accordingly. |
ghost
mentioned this pull request
Jun 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Low
Less than 64 lines changed.
Type: Refactor
The pull request improves or enhances an existing implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
FilterWallets
andWalletsControl
to dashboard domainChecklist