Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore: organise tests according to guidelines #2146

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jun 16, 2020

Follow https://github.com/ArkEcosystem/desktop-wallet/blob/3.0-react/CODING_STANDARDS.md to flatten the structure, make it more obvious what tests what without having to go through multiple nested directories and force smaller directories with focused components and tests.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Jun 16, 2020
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #2146 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2146    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             45        97    +52     
  Lines            298       741   +443     
  Branches          49       113    +64     
============================================
+ Hits             298       741   +443     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Circle/Circle.tsx 100.00% <ø> (ø)
src/app/components/Divider/Divider.styles.ts 100.00% <ø> (ø)
src/app/components/Divider/Divider.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
src/app/components/Select/Select.tsx 100.00% <ø> (ø)
...app/components/SideBar/SideBarItem/SideBarItem.tsx 100.00% <ø> (ø)
src/app/components/StepIndicator/StepIndicator.tsx 100.00% <ø> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcf0e9b...4675ed7. Read the comment docs.

@faustbrian faustbrian merged commit 4ade080 into 3.0-react Jun 16, 2020
@ghost ghost deleted the test-standards branch June 16, 2020 05:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant