This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2153 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 24 100 +76
Lines 142 773 +631
Branches 18 117 +99
============================================
+ Hits 142 773 +631
Continue to review full report at Codecov.
|
…ktop-wallet into feat/expose-environment
@clucasalcantara conflicts and e2e is red |
Closing in favour of #2159. we will, later on, need some things from here to get ledger integrated but we will work on that once the time comes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: High
More than 256 lines changed.
Type: Feature
The issue is a request for new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2065
Adds
profiles
fromplatform-sdk
.A few changes are made to make this integration work since
platform-sdk
relies on the ledger lib some workarounds were needed. The major impact will be on the speed to install any library since thepost-install
script will run and before ayarn dev
when theelectron-rebuild
will be needed to match versions and references.If you have any problems running tests from a
yarn test
cmd after ayarn dev, just run
npm rebuildor a
yarn` to refresh modules refs.Checklist