Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: expose environment #2153

Closed
wants to merge 31 commits into from
Closed

Conversation

clucasalcantara
Copy link
Contributor

@clucasalcantara clucasalcantara commented Jun 16, 2020

Summary

Resolves #2065

Adds profiles from platform-sdk.

A few changes are made to make this integration work since platform-sdk relies on the ledger lib some workarounds were needed. The major impact will be on the speed to install any library since the post-install script will run and before a yarn dev when the electron-rebuild will be needed to match versions and references.

If you have any problems running tests from a yarn test cmd after a yarn dev, just run npm rebuildor ayarn` to refresh modules refs.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Jun 16, 2020
@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Jun 16, 2020
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #2153 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2153    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             24       100    +76     
  Lines            142       773   +631     
  Branches          18       117    +99     
============================================
+ Hits             142       773   +631     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/StepIndicator/StepIndicator.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20ec3a...bd2655c. Read the comment docs.

@faustbrian
Copy link
Contributor

@clucasalcantara conflicts and e2e is red

@faustbrian
Copy link
Contributor

Closing in favour of #2159. we will, later on, need some things from here to get ledger integrated but we will work on that once the time comes.

@faustbrian faustbrian closed this Jun 17, 2020
@faustbrian faustbrian deleted the feat/expose-environment branch August 5, 2020 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants