Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore: rename NavigationHeader to NavHeader #2169

Closed
wants to merge 5 commits into from

Conversation

brenopolanski
Copy link
Contributor

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #2169 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2169    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             24       112    +88     
  Lines            142       884   +742     
  Branches          18       136   +118     
============================================
+ Hits             142       884   +742     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/StepIndicator/StepIndicator.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d5a81...34c6d97. Read the comment docs.

@faustbrian
Copy link
Contributor

faustbrian commented Jun 18, 2020

@faustbrian
Copy link
Contributor

faustbrian commented Jun 18, 2020

Closing this due to the violation of non-abbreviated and clear names in the naming conventions document. The router changes can be submitted in a separate PR if they are needed.

@faustbrian faustbrian closed this Jun 18, 2020
@brenopolanski brenopolanski deleted the chore/rename-navigation-header branch June 18, 2020 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants