This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
test: add HTTP tests that cover actual behaviours #2174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
HttpClient
tests mocked everything which meant nothing was actually tested. The tests now use fake response withnock
which makes sure that requests are sent to the correct URLs and return an actual response body.Replaced
axios
withnode-fetch
because it was causing problems withnock
but both of them anyways are just temporary solutions because something else will have to be used to support proxies.