Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: select delegate modal #2182

Merged
merged 57 commits into from
Jun 19, 2020
Merged

feat: select delegate modal #2182

merged 57 commits into from
Jun 19, 2020

Conversation

alexbarnsley
Copy link
Member

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Jun 18, 2020
Brian Faust and others added 16 commits June 18, 2020 15:43
wip
e95bb81
Merge branch '3.0-react' into feat/select-delegate-modal
1f7c08a
@boldninja
chore: optimize 2 SVG(s)
ced39bf 
Optimized SVG(s):
- src/app/assets/svg/link.svg
- src/app/assets/svg/search.svg
@boldninja @actions-user
style: resolve style guide violations
44e716e
@faustbrian
Merge branch '3.0-react' into feat/select-delegate-modal
83e8e12
@faustbrian
Merge branch '3.0-react' into feat/select-delegate-modal
d5960de
@faustbrian @actions-user
style: resolve style guide violations
5322779
@faustbrian
Merge branch '3.0-react' into feat/select-delegate-modal
e9b756e
@alexbarnsley
chore: update snapshots
ed75d7c
@alexbarnsley
refactor: use current colour in up arrow svg
fa1c8d4
@alexbarnsley
refactor: primary solid button white text
fee8cf4
@alexbarnsley
refactor: allow larger modal
a599b11
@alexbarnsley
chore: update common translations
e531ca8
@alexbarnsley
refactor: lighter bg on search bar
0b6b0e1
@alexbarnsley
feat: radio button component
36749b2
@alexbarnsley
refactor: allow multiple selection
9b14664
@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #2182 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2182    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             45       127    +82     
  Lines            298      1025   +727     
  Branches          49       162   +113     
============================================
+ Hits             298      1025   +727
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Circle/Circle.tsx 100.00% <ø> (ø)
src/app/components/Divider/Divider.styles.ts 100.00% <ø> (ø)
src/app/components/Divider/Divider.tsx 100.00% <ø> (ø)
src/app/components/Form/Form.tsx 100.00% <ø> (ø)
src/app/components/Form/FormField.tsx 100.00% <ø> (ø)
src/app/components/Form/FormHelperText.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acbc6b3...084bffe. Read the comment docs.

@alexbarnsley
Merge branch 'feat/select-delegate-modal' of github.com:arkecosystem/…
bfc0a29 
…desktop-wallet into feat/select-delegate-modal
@alexbarnsley alexbarnsley marked this pull request as ready for review June 18, 2020 21:35
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jun 18, 2020
@faustbrian
Copy link
Contributor

@alexbarnsley conflicts

@faustbrian
Copy link
Contributor

@alexbarnsley build fails

@faustbrian
Copy link
Contributor

@alexbarnsley

    console.error node_modules/react-dom/cjs/react-dom.development.js:88
      Warning: A component is changing an uncontrolled input of type radio to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components

alexbarnsley and others added 14 commits June 19, 2020 11:12
@alexbarnsley
Merge branch '3.0-react' into feat/select-delegate-modal
12e1c04
@alexbarnsley
fix: add missing modal width
b4a1dbe
@alexbarnsley
chore: update select account snap
8e279d8
@alexbarnsley
refactor: selected delegates list
109cf5a
@faustbrian
Merge branch '3.0-react' into feat/select-delegate-modal
3b2c855
@alexbarnsley
refactor: rename modal
7edb3d4
@faustbrian
Merge branch '3.0-react' into feat/select-delegate-modal
3210d33
@faustbrian @actions-user
style: resolve style guide violations
33a74f6
@alexbarnsley
Merge branch '3.0-react' into feat/select-delegate-modal
908e9a0
@faustbrian
Merge branch '3.0-react' into feat/select-delegate-modal
10ac8ba
Merge branch '3.0-react' into feat/select-delegate-modal
6fbc0f6
Merge remote-tracking branch 'origin/feat/select-delegate-modal' into…
82bb378 
… feat/select-delegate-modal
@faustbrian @actions-user
style: resolve style guide violations
2076847
@faustbrian
Merge branch '3.0-react' into feat/select-delegate-modal
084bffe
@faustbrian faustbrian merged commit 071495e into 3.0-react Jun 19, 2020
@ghost ghost deleted the feat/select-delegate-modal branch June 19, 2020 14:45
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jun 19, 2020
@ghost ghost mentioned this pull request Jun 21, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

Assignees
No one assigned
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexbarnsley @faustbrian @boldninja