fix: profile domain tweaks #2183
Conversation
ghost
added
Complexity: Low
| setProfiles(env.profiles().all()); | ||
| env.profiles() | ||
| .all() | ||
| .then((profiles: any) => setProfiles(profiles)); |
There was a problem hiding this comment.
Why would a sync method have to use then? https://github.com/ArkEcosystem/platform-sdk/blob/master/packages/platform-sdk-profiles/src/repositories/profile-repository.ts#L30-L32
There was a problem hiding this comment.
Yeah, you are right! I was just looking at the story https://github.com/ArkEcosystem/desktop-wallet/blob/3.0-react/src/domains/profile/pages/Welcome/Welcome.stories.tsx#L18-L30. So, for this case the promise will always log pending as long as its results are not resolved yet.
| key={profile.id()} | ||
| name={profile.name} | ||
| avatar={profile.avatar} | ||
| balance={profile.balance} |
There was a problem hiding this comment.
This doesn't exist on the profile yet.
| balance="0" | ||
| key={profile.id()} | ||
| name={profile.name} | ||
| avatar={profile.avatar} |
| avatar={profile.avatar()} | ||
| balance="0" | ||
| key={profile.id()} | ||
| name={profile.name} |
| name={profile.name} | ||
| avatar={profile.avatar} | ||
| balance={profile.balance} | ||
| key={profile.id} |
| export const Default = () => { | ||
| const env = { | ||
| profiles: () => ({ | ||
| all: async () => new Promise((resolve) => resolve([])), |
There was a problem hiding this comment.
| <div className="block w-12 h-12 mx-auto rounded-full sm:mx-0 sm:flex-shrink-0"> | ||
| <img | ||
| className="rounded-full" | ||
| src={avatar} |
There was a problem hiding this comment.
The avatar is purely CSS, not an image.
My mistake sorry. PR closed! |
ghost
mentioned this pull request
Summary
.then()to capture promise resultsChecklist