Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add generic DeleteResource component #2186

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Conversation

dated
Copy link
Contributor

@dated dated commented Jun 18, 2020

Summary

This PR adds a generic DeleteResource component that can be reused across different domains. Also refactors (and adds) the DeleteContact and DeleteWallet components to use the new component.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner June 18, 2020 15:27
@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #2186 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2186    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             45       116    +71     
  Lines            298       917   +619     
  Branches          49       140    +91     
============================================
+ Hits             298       917   +619     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Circle/Circle.tsx 100.00% <ø> (ø)
src/app/components/Divider/Divider.styles.ts 100.00% <ø> (ø)
src/app/components/Divider/Divider.tsx 100.00% <ø> (ø)
src/app/components/Form/Form.tsx 100.00% <ø> (ø)
src/app/components/Form/FormField.tsx 100.00% <ø> (ø)
src/app/components/Form/FormHelperText.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa4b36...b54882f. Read the comment docs.

@faustbrian faustbrian merged commit b50913d into 3.0-react Jun 18, 2020
@ghost ghost deleted the feat/delete-resource branch June 18, 2020 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants