Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: details modals tweaks #2194

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Jun 18, 2020

Summary

  • Fixed positioning of the Amount icon
  • Removed border of top row on Vote modal

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #2194 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2194    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             45       117    +72     
  Lines            298       930   +632     
  Branches          49       144    +95     
============================================
+ Hits             298       930   +632     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Circle/Circle.tsx 100.00% <ø> (ø)
src/app/components/Divider/Divider.styles.ts 100.00% <ø> (ø)
src/app/components/Divider/Divider.tsx 100.00% <ø> (ø)
src/app/components/Form/Form.tsx 100.00% <ø> (ø)
src/app/components/Form/FormField.tsx 100.00% <ø> (ø)
src/app/components/Form/FormHelperText.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96726c3...1fae41f. Read the comment docs.

@alexbarnsley alexbarnsley changed the title refactor: modals update amount icon position refactor: details modals tweaks Jun 18, 2020
@faustbrian faustbrian merged commit d10a635 into 3.0-react Jun 19, 2020
@ghost ghost deleted the refactor/tx-detail-modals-tweaks branch June 19, 2020 01:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants