Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: add ContactForm component #2207

Merged
merged 4 commits into from
Jun 21, 2020
Merged

feat: add ContactForm component #2207

merged 4 commits into from
Jun 21, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Jun 21, 2020

Summary

Extracts the form used on the create contact modal into it's own component so it can be used also for editing a contact and adds some basic logic to the form inputs and buttons.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@dated dated requested a review from faustbrian as a code owner June 21, 2020 01:25
@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. labels Jun 21, 2020
@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #2207 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           3.0-react     #2207    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             45       140    +95     
  Lines            298      1195   +897     
  Branches          49       201   +152     
============================================
+ Hits             298      1195   +897     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Circle/Circle.tsx 100.00% <ø> (ø)
src/app/components/Divider/Divider.styles.ts 100.00% <ø> (ø)
src/app/components/Divider/Divider.tsx 100.00% <ø> (ø)
src/app/components/Form/Form.tsx 100.00% <ø> (ø)
src/app/components/Form/FormField.tsx 100.00% <ø> (ø)
src/app/components/Form/FormHelperText.tsx 100.00% <ø> (ø)
src/app/components/Form/FormLabel.tsx 100.00% <ø> (ø)
... and 149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ebb1d...9fb8718. Read the comment docs.

@faustbrian faustbrian merged commit 78a20ec into 3.0-react Jun 21, 2020
@ghost ghost deleted the feat/contact-form branch June 21, 2020 02:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants