Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: exchanges page #2229

Merged
merged 23 commits into from
Jun 23, 2020
Merged

feat: exchanges page #2229

merged 23 commits into from
Jun 23, 2020

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Jun 23, 2020 •
edited by faustbrian
Loading

No description provided.

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Jun 23, 2020
@faustbrian faustbrian marked this pull request as ready for review June 23, 2020 02:14
@faustbrian faustbrian self-requested a review as a code owner June 23, 2020 02:14
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jun 23, 2020
@faustbrian faustbrian marked this pull request as draft June 23, 2020 02:15
boldninja and others added 4 commits June 23, 2020 04:15
@boldninja
chore: optimize 3 SVG(s)
7fde750 
Optimized SVG(s):
- src/domains/exchange/images/changenow-logo.svg
- src/domains/exchange/images/exchange-cards-banner.svg
- src/domains/exchange/images/no-exchanges-banner.svg
@boldninja
chore: optimize 2 SVG(s)
9bc9c50 
Optimized SVG(s):
- src/domains/exchange/images/exchange-cards-banner.svg
- src/domains/exchange/images/no-exchanges-banner.svg
@boldninja @actions-user
style: resolve style guide violations
8a3b739
@faustbrian
Merge branch '3.0-react' into feat/exchanges-page
bd3fb55
@codecov
Copy link

codecov bot commented Jun 23, 2020 •
edited
Loading

Codecov Report

Merging #2229 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2229     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       162    +138     
  Lines            142      1427   +1285     
  Branches          18       245    +227     
=============================================
+ Hits             142      1427   +1285
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3814fb3...fd10ad4. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review June 23, 2020 07:52
@faustbrian faustbrian merged commit 5b16d95 into 3.0-react Jun 23, 2020
@ghost ghost deleted the feat/exchanges-page branch June 23, 2020 08:06
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jun 23, 2020
@ghost ghost mentioned this pull request Jun 28, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian faustbrian approved these changes

Assignees
No one assigned
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexbarnsley @faustbrian @boldninja