Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: integrate RecipientsList in Transaction flow #2237

Merged
merged 3 commits into from Jun 23, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jun 23, 2020

Summary

Depends on #2234
Integrate RecipientList into SendTransactionForm and SendTransaction views.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. Status: In Progress The issue or pull request is being worked on. labels Jun 23, 2020
@goga-m goga-m marked this pull request as ready for review June 23, 2020 12:27
@goga-m goga-m requested a review from faustbrian as a code owner June 23, 2020 12:27
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Jun 23, 2020
@clucasalcantara
Copy link
Contributor

@goga-m Well done isolating this :3 but looks like that you forgot to add the index reflection for the recipient list so your import is not working :3

giphy

@clucasalcantara
Copy link
Contributor

Forget about it, depends on >.<

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #2237 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2237     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       168    +144     
  Lines            142      1461   +1319     
  Branches          18       252    +234     
=============================================
+ Hits             142      1461   +1319     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ade22...26aba58. Read the comment docs.

@faustbrian faustbrian merged commit ffca230 into 3.0-react Jun 23, 2020
@ghost ghost deleted the refactor/integrate-recipients-in-tx-steps branch June 23, 2020 14:47
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants