This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
feat: add My Contacts page #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Undetermined
Optimized SVG(s): - src/domains/contacts/images/contacts-banner.svg
|
@dated failing tests |
faustbrian
reviewed
Jun 24, 2020
| @@ -38,7 +38,7 @@ export const Address = ({ address, addressClass, walletName, maxChars, size }: P | |||
| addressClass || (walletName ? "text-theme-neutral-400" : "text-theme-neutral-800") | |||
| } font-semibold ${size && fontSizes[size]}`} | |||
| > | |||
| {truncateStringMiddle(address, maxChars)} | |||
| {maxChars && maxChars > 0 ? truncateStringMiddle(address, maxChars) : address} | |||
There was a problem hiding this comment.
Should the maxChars && maxChars > 0 part be handled inside truncateStringMiddle so that it would return the value without any truncating if it is false? Then it would apply to all places that use truncateStringMiddle and not just this place.
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2243 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 177 +153
Lines 142 1544 +1402
Branches 18 270 +252
=============================================
+ Hits 142 1544 +1402
Continue to review full report at Codecov.
|
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the My Contact page.
Checklist