Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: add minimum colored bg width to InputRange #2244

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jun 23, 2020

Summary

Fix background width of InputRange when value is zero.
Should still show a minimum background color when zero.
2020-06-23-195906_354x115_scrot

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner June 23, 2020 17:03
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jun 23, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #2244 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2244     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       169    +145     
  Lines            142      1469   +1327     
  Branches          18       254    +236     
=============================================
+ Hits             142      1469   +1327     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0102c...3441b22. Read the comment docs.

@faustbrian faustbrian merged commit 74b9210 into 3.0-react Jun 24, 2020
@ghost ghost deleted the fix/input-range-min-bg-width branch June 24, 2020 01:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants