This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
refactor: plugin settings ui adjustments #2254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2254 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 186 +162
Lines 142 1625 +1483
Branches 18 281 +263
=============================================
+ Hits 142 1625 +1483
Continue to review full report at Codecov.
|
Requested a change on this, once implemented. Will be good for approval. |
samharperpittam
approved these changes
Jun 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Low
Less than 64 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task: https://trello.com/c/457LQe6Q/77-plugin-settings#comment-5ef0b61f24923b40a61a89ed
Checklist