Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: plugin settings ui adjustments #2254

Merged
merged 11 commits into from
Jun 26, 2020
Merged

Conversation

brenopolanski
Copy link
Contributor

Summary

Task: https://trello.com/c/457LQe6Q/77-plugin-settings#comment-5ef0b61f24923b40a61a89ed

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jun 25, 2020
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #2254 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2254     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       186    +162     
  Lines            142      1625   +1483     
  Branches          18       281    +263     
=============================================
+ Hits             142      1625   +1483     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)
Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/Card.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Address/utils.ts 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.styles.ts 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Button/Button.styles.ts 100.00% <100.00%> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad5758...3164f71. Read the comment docs.

@samharperpittam
Copy link
Contributor

Requested a change on this, once implemented. Will be good for approval.

@brenopolanski brenopolanski changed the title fix: update plugin settings with some improvements in the UI refactor: plugin settings ui adjustments Jun 26, 2020
@faustbrian faustbrian merged commit 82873ba into 3.0-react Jun 26, 2020
@ghost ghost deleted the fix/plugin-settings branch June 26, 2020 01:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants